Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient support for PROXY protocol #4421

Closed
sbordet opened this issue Dec 13, 2019 · 0 comments
Closed

HttpClient support for PROXY protocol #4421

sbordet opened this issue Dec 13, 2019 · 0 comments
Assignees
@sbordet
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 13, 2019

Jetty version
9.4.x

Description
Introduce support for the PROXY protocol V1 and V2 in HttpClient.
@sbordet sbordet self-assigned this Dec 13, 2019
@sbordet sbordet added Sponsored This issue affects a user with a commercial support agreement Enhancement labels Dec 13, 2019
sbordet added a commit that referenced this issue Dec 15, 2019
@sbordet
Fixes #4421 - HttpClient support for PROXY protocol.
ea92b2c 
Implemented support for the PROXY protocol in HttpClient.

Introduced Request.tag(Object) to tag requests that belong
to the same group (e.g. a client address) so that they can
generate a different destination.

The tag object may implement ClientConnectionFactory.Decorator
so that it can decorate the HttpDestination ClientConnectionFactory
and therefore work both with and without forward proxy configuration.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw gregw mentioned this issue Dec 15, 2019
Merged
sbordet added a commit that referenced this issue Dec 16, 2019
@sbordet
Fixes #4421 - HttpClient support for PROXY protocol.
bde931a 
Updates after review.
Renamed Info -> Tag.
Added convenience constructors to class Tag.
Added test and server support for PROXY V1 UNKNOWN.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Dec 17, 2019
@sbordet
Fixes #4421 - HttpClient support for PROXY protocol.
09d4ee0 
Updates after review.
Improved javadocs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Dec 17, 2019
@sbordet
Fixes #4421 - HttpClient support for PROXY protocol.
bea7f1a 
Improved support for Type-Length-Value (TLV) objects.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet mentioned this issue Dec 17, 2019
Merged
sbordet added a commit that referenced this issue Dec 17, 2019
@sbordet
Merge pull request #4429 from eclipse/jetty-9.4.x-4421-httpclient_pro…
fcc18b0 
…xy_protocol2

Fixes #4421 - HttpClient support for PROXY protocol.
sbordet added a commit that referenced this issue Dec 19, 2019
@sbordet
Fixes #4421 - HttpClient support for PROXY protocol.
e4f1106 
Fixed visibility of ProxyProtocolConnection.
Must be protected because it's the return type
of protected methods.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbordet