Use addEventListener(EventListener listener) #2578
Comments
gregw
added a commit
that referenced
this issue
Aug 13, 2019
Use addEventListener rather than bespoke listener methods. Support getEventListenerBeans at Container level for fast lookup improve javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 13, 2019
fixed test more javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 13, 2019
fixed tests Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
Resolve differences between eventListeners added as beans and beans added as EventListeners. The behaviour should now be the same regardless of how they listener is added and all listeners are now beans. Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
Add only SelectorManager listeners to manager from connector Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
Fixed javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
removed old TODO Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
connector cannot be null Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 14, 2019
fixed merge Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Aug 19, 2019
removed the ability to set/clear context listeners Instead just remove non-durable ones. Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
added a commit
that referenced
this issue
Nov 13, 2019
* Avoid creating listener list for rarely used requestAttributeListener Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 Keep a list of EventListeners in the AbstractConnector to make it more efficient to add and iterate over them. Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener Use addEventListener rather than bespoke listener methods. Support getEventListenerBeans at Container level for fast lookup improve javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener fixed test more javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener fixed tests Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 Don't use null for empty lists of listeners Signed-off-by: Greg Wilkins <gregw@webtide.com> * fix merge Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener Resolve differences between eventListeners added as beans and beans added as EventListeners. The behaviour should now be the same regardless of how they listener is added and all listeners are now beans. Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener Add only SelectorManager listeners to manager from connector Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener Fixed javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener removed old TODO Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener connector cannot be null Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 AbstractConnector keeps a specific list of HttpChannel.Listeners to avoid Connection.Listeners and MBean listeners being added to the HttpChannel listener list. Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener fixed merge Signed-off-by: Greg Wilkins <gregw@webtide.com> * fixed javadoc Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #2578 EventListener removed the ability to set/clear context listeners Instead just remove non-durable ones. Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 Listeners Simplified listener handling by avoiding null connector, previously only needed for testing. Signed-off-by: Greg Wilkins <gregw@webtide.com> * fixed bad merge Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 Listeners Fixed test that assumed HttpChannel listeners were not cleared by a recycle Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #3964 Listeners Separated out durable vs cyclic HttpChannel.Listeners, so as to simplify handling. Deprecated cyclic HttpChannel.Listeners, as I'm not sure the channel is the right place for them. Signed-off-by: Greg Wilkins <gregw@webtide.com> * removed deprecated cyclic HttpChannel listeners Signed-off-by: Greg Wilkins <gregw@webtide.com> * removed deprecated cyclic HttpChannel listeners - import Signed-off-by: Greg Wilkins <gregw@webtide.com> * Issue #4003 Cleanup quickstart * Fixed tests that scan for "Started" on console Signed-off-by: Greg Wilkins <gregw@webtide.com> * updates from review Signed-off-by: Greg Wilkins <gregw@webtide.com>
|
This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been closed due to it having no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Classes that declare their own listener types should follow the pattern of having those listeners extend
EventListenerand having anaddEventListener(EventListener listener)method.Existing API to add listeners by specific type can either be retained as an alternative or deprecated.
Examples that need to be updated include:
The text was updated successfully, but these errors were encountered: