Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake] php extensions example project #631

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[flake] php extensions example project #631

merged 1 commit into from
Feb 17, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Feb 14, 2023 •
edited
Loading

Summary

Added an example devbox-project that has a php extension package. This has been useful for doing adhoc testing when developing the feature of "flakes with php extensions". In a future PR, I'll add a testscript (and possibly remove this one).

How was it tested?

> devbox shell

# with package `php81Extensions.ds`
> php index.php
Original vector elements
idx: 0 and elem: hello
idx: 1 and elem: world
done

# without package `php81Extensions.ds` 
> php index.php
ds extension is not enabled

@savil Graphite App
Copy link
Collaborator Author

savil commented Feb 14, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil force-pushed the savil/enable-php-extensions branch from 21e0867 to cd1d62c Compare February 15, 2023 13:36
@savil savil mentioned this pull request Feb 15, 2023
Merged
1 task
@savil savil changed the title [flake] enable php extensions [flake] php extensions example/testscript Feb 15, 2023
@savil savil mentioned this pull request Feb 16, 2023
Closed
@savil savil changed the title [flake] php extensions example/testscript [flake] php extensions example project Feb 16, 2023
@savil savil force-pushed the savil/enable-php-extensions branch from cd1d62c to 3df1cb5 Compare February 16, 2023 23:08
@savil savil requested review from gcurtis and ipince February 16, 2023 23:08
@savil savil marked this pull request as ready for review February 16, 2023 23:09
ipince
ipince approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ipince ipince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about phpExtensions, but this is a simple test project so LGTM

@savil savil force-pushed the savil/enable-php-extensions branch from 3df1cb5 to 1d4a3b0 Compare February 17, 2023 00:58
@savil savil merged commit 22b5b48 into main Feb 17, 2023
@savil savil deleted the savil/enable-php-extensions branch February 17, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipince ipince ipince approved these changes

@gcurtis gcurtis Awaiting requested review from gcurtis

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savil @ipince