Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove init rec feature #1890

Merged
merged 4 commits into from
Mar 12, 2024
Merged

[cleanup] Remove init rec feature #1890

merged 4 commits into from
Mar 12, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

This feature is not really maintained and out of date. I think value is fairly limited.

fixes #1788

How was it tested?

CICD

@mikeland73 mikeland73 requested review from gcurtis, savil and Lagoja March 11, 2024 22:38
savil
savil approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

gcurtis
gcurtis approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@gcurtis gcurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@mikeland73 mikeland73 merged commit 25e35f2 into main Mar 12, 2024
24 checks passed
@mikeland73 mikeland73 deleted the landau/remove-init-rec branch March 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savil savil savil approved these changes

@gcurtis gcurtis gcurtis approved these changes

@Lagoja Lagoja Awaiting requested review from Lagoja

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting Python recommendations
3 participants
@mikeland73 @gcurtis @savil