Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tyson] Add tyson support experiment #1656

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[tyson] Add tyson support experiment #1656

merged 2 commits into from
Nov 30, 2023

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Nov 30, 2023

Summary

Minimal viable implementation of tyson support. This allows user to opt-in via feature flag and a devbox.tson config. It has no effect for non-opt

Proof of concept of how this can be used: https://github.com/jetpack-io/frontend/pull/504 (warning private repo)

To simplify this implementation, it is not possible to use any devbox command that writes to devbox.json. It will fail with an error. We will also show an error if both configs are present.

Tyson allows more programatic logic in our configs. Specifically:

  • Allows importing other configs which adds composability.
  • Allows importing of other package manager files (e.g. package.json, composer.json, etc which allows you to mimic and enhance their functionality)
  • Allows you to customize hooks, packages, and scripts using host environment variables. (Proof of concept)

How was it tested?

  • Tested in the proof of concept link above.
  • CICD

@mikeland73 mikeland73 requested review from gcurtis and loreto November 30, 2023 01:22
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeland73 mikeland73 merged commit a3135c6 into main Nov 30, 2023
@mikeland73 mikeland73 deleted the landau/tyson branch November 30, 2023 23:03
Copy link

sentry-io bot commented Dec 6, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **Generic Error: <redacted errors.withStack>: <redacted errors.fundamental> go.jetpack.io/devbox/internal/devconfig in vali... View Issue
  • ‼️ **Generic Error: <redacted errors.withStack>: <redacted errors.fundamental> go.jetpack.io/devbox/internal/devconfig in vali... View Issue
  • ‼️ **Generic Error: error reading devbox.json: <redacted errors.withStack>: <redacted errors.fundamental> go.jetpack.io/devbox/internal/devconfig in vali... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants