Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugins] Remove trigger package #1545

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

mikeland73
Copy link
Contributor

Summary

Previously, we were expecting $buildInputs to match the order of $PATH, specifically, packages installed first appeared first (in both $PATH and $buildInputs). This would allow us to prioritize the first binary that shows up. In a few plugins we add a flake that installs a wrapped or alternate version of the binary. We were relying on the order of $buildInputs to point to the correct wrapped binary.

It looks like $buildInputs is not deterministic, or something in the mariadb/mysql case caused the order to change.

The solution in this PR is to add a new __remove_trigger_package field that when set to true tells devbox to remove the package that causes the plugin to be installed. This does not affect plugins installed include field.

This has the additional benefit of not installing unnecessary packages in nix profile.

How was it tested?

devbox init
devbox add mysql
devbox shell

Also verified that PHP plugin works as expected. Note that in the PHP case the user should avoid installing composer themselves. It is included in our php plugin.

@mikeland73 mikeland73 requested review from savil and Lagoja October 9, 2023 23:00
@Lagoja Lagoja linked an issue Oct 10, 2023 that may be closed by this pull request
@mikeland73 mikeland73 merged commit cd4f67c into main Oct 10, 2023
@mikeland73 mikeland73 deleted the landau/remove_trigger_package branch October 10, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MariaDB fails to start
2 participants