Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we were expecting
$buildInputs
to match the order of $PATH, specifically, packages installed first appeared first (in both $PATH and $buildInputs). This would allow us to prioritize the first binary that shows up. In a few plugins we add a flake that installs a wrapped or alternate version of the binary. We were relying on the order of$buildInputs
to point to the correct wrapped binary.It looks like
$buildInputs
is not deterministic, or something in the mariadb/mysql case caused the order to change.The solution in this PR is to add a new
__remove_trigger_package
field that when set to true tells devbox to remove the package that causes the plugin to be installed. This does not affect plugins installedinclude
field.This has the additional benefit of not installing unnecessary packages in nix profile.
How was it tested?
Also verified that PHP plugin works as expected. Note that in the PHP case the user should avoid installing composer themselves. It is included in our php plugin.