Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testscripts] augment php testscrpt to remove and re-add a php-extension #1021

Merged
merged 1 commit into from
May 18, 2023
Merged

[testscripts] augment php testscrpt to remove and re-add a php-extension #1021

merged 1 commit into from
May 18, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented May 18, 2023

Summary

When reviewing #1000, I found myself wanting to ensure the test plan of #648 was used.

So, I added it to testscripts. It works :)

How was it tested?

go test -run TestScripts/php ./testscripts/...

@savil Graphite App
Copy link
Collaborator Author

savil commented May 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested a review from mikeland73 May 18, 2023 04:11
mikeland73
mikeland73 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

btw, another way to tell is extension is installed:

php -m | grep ds

@savil savil merged commit 88583f8 into main May 18, 2023
@savil savil deleted the savil/augment-php-testscript branch May 18, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savil @mikeland73