Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file encryption by default #90

Merged
merged 4 commits into from
Feb 16, 2020

Conversation

chip2n
Copy link
Contributor

@chip2n chip2n commented Feb 16, 2020

If org-roam-encrypt-files is t, org-roam creates files with .org.gpg extension instead.

Might be a good idea to rename org-roam--get-file-path to org-roam--make-new-file-path, since given an existing ID it no longer reliably gets the path for it (could be either encrypted or unencrypted). I think it's only used for creating new files now anyways.

See #85

If org-roam-encrypt-files is t, org-roam creates files with .org.gpg
extension instead.

See org-roam#85
@jethrokuan
Copy link
Member

I think it's only used for creating new files now anyways.

Yep you're right. Could you do that as well? Also, org-roam-encrypt-files could use a short para in the documentation. https://github.com/jethrokuan/org-roam/blob/develop/doc/configuration.md

@chip2n
Copy link
Contributor Author

chip2n commented Feb 16, 2020

Done!

Copy link
Member

@jethrokuan jethrokuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thank you!

@jethrokuan jethrokuan merged commit 159b64b into org-roam:develop Feb 16, 2020
@chip2n chip2n deleted the feature/encryption-default branch February 16, 2020 11:04
@rileyrg
Copy link

rileyrg commented Aug 5, 2021

what/if any key variable does/can his default to? gnupg.conf default-key isnt used, epa-file-encrypt-to doesnt seem to work either. I'm constantly prompted to mark my only encrpytion key.

kisaragi-hiu pushed a commit to kisaragi-hiu/minaduki that referenced this pull request Sep 2, 2021
- anystyle requires absolute file paths, ensure it's happy
- improve training session messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants