New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency changes/fixes for `ISyncContext.Version` #282

Merged

bartelink merged 1 commit into v2 from version-fixes

Mar 11, 2021

Collaborator

bartelink commented Mar 11, 2021

This addresses a problem at two levels:

Equinox.Cosmos v 2.5.0 can return a Version of 0 when re-reading a stream that
a) uses AccessStrategy.Unoptimized
b) uses a cache
the Version field was defined in an ambiguous manner, indicating it was a store-native version field
a) That doesn't make sense for an interface in the Equinox package
b) There's a reasonable general way to express it in a neutral way

The fix consists of:

a doc change for the property
patching the bug in the corner case that caused the actual issue (will follow up with a V3 edition of this shortly - its likely that the events in Tip impl removed the issue on that side)
changing the impl of the SSS, ESDB and MemoryStore stores to match the new definition

bartelink force-pushed the version-fixes branch 2 times, most recently from a8a3fa5 to debcef7 Compare

March 11, 2021 18:19


          ISyncContext.Version fixes/changes

7308b37

bartelink force-pushed the version-fixes branch from debcef7 to 7308b37 Compare

March 11, 2021 23:01

bartelink merged commit 2d6bfe0 into v2

bartelink deleted the version-fixes branch

March 11, 2021 23:01

bartelink added a commit that referenced this pull request


          ISyncContext.Version fixes/changes as v2 #282

1655cb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet