Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Equinox.Codec out to FsCodec #156

Merged
merged 13 commits into from
Aug 30, 2019
Merged

Move Equinox.Codec out to FsCodec #156

merged 13 commits into from
Aug 30, 2019

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Aug 29, 2019

Splits Equinox.Codec into an interfaces library an an impl library, in order to reduce boilerplate at the point of consumption.

The resulting libraries will likely move to be merged with https://github.com/jet/Jet.JsonNet.Converters

Resolves some aspects of #79

Concerns to be resolved before merge:

  • should there be a CreateDefault (mirroring the default settings for the serializer) and a Create with different policies which pave for a pit of success
    • with an OptionConverter in by default
    • with a ListConverter there will be no ListConverter, the advice will be to use arrays
    • with NullHandling.Ignore on (i.e. prevent emitting null for null strings and missing options) agreed that sticking with defaults is good
  • should Gardelloyd.Custom.Create(encode,tryDecode) become Gardelloyd.Codec.Create(encode,tryDecode) or would the overloading of Codec (and the adjacent Gardelloyd.Core make a mess ??
  • Final name: FsCodec

@bartelink bartelink changed the title Prepare externalization of serialization interfaces and impl Move Equinox.Codec out to FsCodec Aug 30, 2019
@bartelink bartelink marked this pull request as ready for review August 30, 2019 14:05
@bartelink bartelink merged commit 3520192 into master Aug 30, 2019
@bartelink bartelink deleted the gardelloyd branch August 30, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant