Return a promise if no callback specified #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If global.Promise is undefined.
|
I appreciate the PR but I'd rather just stick with good old callbacks. Thanks for the work though! |
|
@jergason I think adding Promises is worthwhile, as it will make life easier for devs who are used to working with them, or who want to avoid using callbacks. Also it's not taking callbacks away, they can still be used. |
|
Not just that, but they're now a language-level feature (async/await). |
Closed
|
In light of promises becoming more official in node I'm gonna merge this in. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes native promises are available (or have been polyfilled). If they aren't, then you still need to supply a callback function.