Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded minimatch version #39

Merged
merged 8 commits into from
Aug 14, 2016
Merged

Upgraded minimatch version #39

merged 8 commits into from
Aug 14, 2016

Conversation

woodyrew
Copy link
Contributor

Fixes npm deprecation warning:

npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

woodyrew added 2 commits July 29, 2016 16:32
@woodyrew
Upgraded minimatch version
c2a15e3 
Fixes npm deprecation warning:
> npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
@woodyrew
Corrected minimatch version
3786653
@woodyrew
Copy link
Contributor Author

This upgrade causes an issue for Node v0.6 and v0.8. Maybe you could do a major version bump and remove support for those Node versions? I think v10 is end of life now.

@mrmlnc
Copy link

mrmlnc commented Jul 30, 2016

@woodyrew,

Happy to merge this if you also update the .travis.yml to remove node 0.6 and 0.8.
@jergason

@jergason
Copy link
Owner

What he said!

@woodyrew
Copy link
Contributor Author

@jergason, @mrmlnc: Increased engine node version to v0.10 latest version and removed old v0.6 and v0.8 from travis. Also added v5, v6 and latest node version to travis.

@woodyrew woodyrew mentioned this pull request Jul 30, 2016
Closed
@blaenk
Copy link

blaenk commented Jul 31, 2016

Is a new release scheduled for this?

@mrmlnc
Copy link

mrmlnc commented Jul 31, 2016 •
edited
Loading

@woodyrew, IMHO:

package.json

Perhaps the user is using not the latest version of this branch. For example: 0.10.32.

"engines": {
  "node": ">=0.10.0"
}

travis.yml

It makes no sense to check each version.

language: node_js
node_js:
  - "6"
  - "5"
  - "4"
  - "0.12"
  - "0.10"

But it's not up to me. @jergason is maintainer.

@woodyrew
Copy link
Contributor Author

woodyrew commented Aug 1, 2016

package.json - Node version

@mrmlnc I agree, I changed the node version as per your suggestion.

travis.yml

  1. With regard to the Travis node versions, I was following the pattern of v4.x. but I thought it was worth adding the latest versions of each major version too.
  2. I added node which equates to the latest release, just in case. For when the next versions is released and travis.yml's not updated.

@mrmlnc I agree with your suggestion but I think node should also be included. What do you think @jergason?

I suggest:

language: node_js
node_js:
  - "node"
  - "6"
  - "5"
  - "4"
  - "0.12"
  - "0.10"

This removes iojs and the minor versions of v4.

@mrmlnc
Copy link

mrmlnc commented Aug 11, 2016

@jergason ping 🐼

@jergason
Copy link
Owner

👍

@jergason jergason merged commit b0114b3 into jergason:master Aug 14, 2016
@woodyrew woodyrew deleted the patch-1 branch August 14, 2016 19:44
@woodyrew
Copy link
Contributor Author

woodyrew commented Aug 14, 2016 •
edited
Loading

Thanks 😄

@mrmlnc
Copy link

mrmlnc commented Aug 14, 2016

Left to do npm publish :)

fson added a commit to fson/create-react-app that referenced this pull request Sep 25, 2016
@fson
Bump recursive-readdir
0381415 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
@fson fson mentioned this pull request Sep 25, 2016
Merged
gaearon pushed a commit to facebook/create-react-app that referenced this pull request Sep 25, 2016
@fson @gaearon
Bump recursive-readdir (#756)
4c183b7 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@fson @feiqitian
Bump recursive-readdir (facebook#756)
e8507b2 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
rrdelaney pushed a commit to rrdelaney/reason-scripts that referenced this pull request May 23, 2018
@fson @gaearon
Bump recursive-readdir (#756)
161ed1c 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
sven3270350 added a commit to sven3270350/react-typescript that referenced this pull request Aug 11, 2022
@sven3270350
Bump recursive-readdir (#756)
19aa62d 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
OrdinalKing pushed a commit to OrdinalKing/create-react-app-ts-redux-saga-mui that referenced this pull request Aug 26, 2022
@fson @OrdinalKing
Bump recursive-readdir (#756)
6e1d549 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
SmartCodiDev added a commit to SmartCodiDev/redux-saga-mui that referenced this pull request May 31, 2024
@SmartCodiDev
Bump recursive-readdir (#756)
8d253a0 
Removes a deprecation warning:
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

See: jergason/recursive-readdir#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woodyrew @mrmlnc @jergason @blaenk