Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Laravel 11 #208

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Compatibility with Laravel 11 #208

merged 4 commits into from
Apr 11, 2024

Conversation

sharafat
Copy link
Contributor

@sharafat sharafat commented Apr 7, 2024

No description provided.

angusm73
angusm73 approved these changes Apr 11, 2024
View reviewed changes
Copy link

@angusm73 angusm73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple suggestions for other packages to bump 🚀

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@sharafat
Copy link
Contributor Author

@angusm73 thanks so much for your careful review and helpful suggestions! 😄 Although for most of the cases the ^ took care of the minor version compatibility and hence this package works in my application without any issues with the minimal changes I had made, I do find your suggestions useful to implement. So here's the updated version!

@jeremykenedy jeremykenedy merged commit 986430a into jeremykenedy:master Apr 11, 2024
4 checks passed
@sharafat
Copy link
Contributor Author

sharafat commented Apr 11, 2024 •
edited
Loading

@jeremykenedy thanks for merging! Could you please also tag a release? Thanks! 🚀

@jeremykenedy jeremykenedy mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremykenedy jeremykenedy jeremykenedy approved these changes

@angusm73 angusm73 angusm73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharafat @angusm73 @jeremykenedy