add pipeline support #176

adelcast · 2017-09-22T21:26:30Z

Add Pipeline support to TFS plugin

jpricket · 2017-09-27T14:27:59Z

tfs/src/main/java/hudson/plugins/tfs/ChangeSetReader.java

@@ -10,30 +10,31 @@
 import java.util.ArrayList;


Ideally, you would remove the //CHECKSTYLE:OFF setting for the files that you modify and correct all the checkstyle warnings and errors in that file.

imho a passing checkstyle run as part of the build is a minimal requirement for a contribution. Just get your IDE to format it correctly in an automated fashion. Or fix it manually if necessary

ok, I removed the //CHECKSTYLE:OFF comments and fixed the fallout

jpricket · 2017-09-27T14:31:26Z

tfs/src/main/java/hudson/plugins/tfs/TeamFoundationServerScm.java

-                    new RemoveWorkspaceAction(workspaceConfiguration.getWorkspaceName()).remove(server);
-                    nodeConfiguration.setWorkspaceWasRemoved();
-                    nodeConfiguration.save();
+                Computer computer = workspaceFilePath.toComputer();


please add final where appropriate (checkstyle will find these)

jpricket · 2017-09-27T14:38:21Z

tfs/src/main/java/hudson/plugins/tfs/TeamFoundationServerScm.java

            while (lastRun != null) {
-                AbstractBuild<?,?> build = lastRun;
+                AbstractBuild<?,?> build = (AbstractBuild)lastRun;


Should we check the "instanceOf" lastRun before casting here?

From the comment I understood that node was only going to be NULL in Hudson core < 1.321, which doesn't support pipelines (so no Run class, just AbstractBuild). But I get that's a bit thin....I went ahead and added a check, just in case

jpricket · 2017-09-27T14:44:22Z

tfs/src/main/java/hudson/plugins/tfs/model/ChangeLogSet.java

@@ -19,16 +21,26 @@

    private final List<ChangeSet> changesets;

+    @Deprecated


A TODO here with information on when we should remove these deprecated methods would help. For instance, should we remove them with the next major version release or can they be removed with the next minor release. A comment on who might be using these methods would also help clarify when they can be removed.

One of the methods is still being used by a few tests (added a comment). Removed the other.

jpricket

The code looks good, but I had a few suggested changes.

kvarec · 2017-10-09T16:03:52Z

TeamFoundationServerScm.buildEnvironment required for envvars from checkout step

adelcast · 2017-10-09T22:18:32Z

@kvarec good catch, fixed

jpricket

Thanks for making the changes!

kvarec · 2017-10-12T04:23:28Z

According to https://issues.jenkins-ci.org/browse/JENKINS-36703 in method TeamFoundationServerScm.calcRevisionsFromBuild required to return SCMRevisionState.NONE instead of null
And then I have exception in polling log:
ERROR: polling failed in /var/lib/jenkins/jobs/MYJOB on build-node-machine
java.lang.ClassCastException: org.jenkinsci.plugins.workflow.job.WorkflowJob cannot be cast to hudson.model.AbstractProject
at hudson.plugins.tfs.TeamFoundationServerScm.compareRemoteRevisionWith(TeamFoundationServerScm.java:693)
at org.jenkinsci.plugins.workflow.job.WorkflowJob.poll(WorkflowJob.java:607)
at hudson.triggers.SCMTrigger$Runner.runPolling(SCMTrigger.java:594)
at hudson.triggers.SCMTrigger$Runner.run(SCMTrigger.java:640)
at hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

adelcast · 2017-10-16T21:45:05Z

@kvarec yep, polling was busted since it was calling a deprecated method that required AbstractProject. I fixed it and ensure polling works as expected.

kvarec · 2017-10-17T04:14:45Z

And from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Ftfs-plugin/detail/PR-176/8/pipeline/17:

tfs\src\main\java\hudson\plugins\tfs\JenkinsEventNotifier.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\listeners\JenkinsRunListener.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\SafeParametersAction.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\TeamFoundationServerScm.java:727:9: error: '{' at column 9 should be on the previous line.
tfs\src\main\java\hudson\plugins\tfs\TeamFoundationServerScm.java:741: error: Line has trailing spaces.
tfs\src\main\java\hudson\plugins\tfs\TeamPRPushTrigger.java:0: error: File does not end with a newline.

adelcast · 2017-10-17T18:14:48Z

I went ahead and fixed the issues in \TeamFoundationServerScm.java, but I still get:

\tfs\src\main\java\hudson\plugins\tfs\JenkinsEventNotifier.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\listeners\JenkinsRunListener.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\SafeParametersAction.java:0: error: File does not end with a newline.
tfs\src\main\java\hudson\plugins\tfs\TeamPRPushTrigger.java:0: error: File does not end with a newline.

however, my change did not touch those files. Furthermore, looking at those files, they do end in a newline, so I am not sure what the linter is complaining about. Could this be a problem on the backend? not sure who can take a look at this.... @kvarec

cdenneen · 2017-10-26T17:02:27Z

@kvarec @adelcast is this build working again?

jpricket · 2017-10-26T17:04:25Z

The build should be up and running again now. Please rebase/merge and try again.

cdenneen · 2017-10-26T17:04:40Z

@adelcast Can you add a doc or to README.md to give sample pipeline code that works with TFS and available parameters that can be used?

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

Follow the guide on https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md. Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

adelcast · 2017-10-27T16:40:22Z

@cdenneen is that really needed? The Snippet Generator already documents that for you. I looked at the Subversion/Git/Mercurial plugins and they don't explicitly document the pipeline usage (they rely on the Snippter Generator)

adelcast · 2017-10-27T17:04:26Z

@jpricketMSFT done, now we have all green, =)

fuzzmz · 2017-11-02T11:43:21Z

Any timeline on when we'll have this merged and a new version of the plugin released?

jpricket · 2017-11-02T15:02:56Z

@fuzzmz - we hope to get this merged and released by the end of next week. Sorry for the delay.

jpricket · 2017-11-02T17:40:42Z

oops, didn't mean to close this.

calmzhu · 2018-01-21T14:26:52Z

So, after use pipeline to checkout tfs. How should we get the changeset since the functions returns a null .Does someone help please

jpricket · 2018-01-21T20:10:43Z

You need to upgrade your version of Jenkins pipeline plugins. I think its 2.5 that fixes the problem where checkout returns null. After you upgrade your pipeline plugins, checkout should return a map with all the TFS environment variables you need.

Tetradeus · 2018-06-08T14:57:38Z

@adelcast, plz can you provide the documentation to trigger a release in vsts via pipeline ?

raulney · 2019-01-15T19:25:05Z

@Tetradeus Did you manged to find any documentation on how to use this plugin via a Scripted/Declarative pipeline?

Tetradeus · 2019-01-15T22:08:17Z

nop, sorry.

trivalik · 2020-09-25T13:21:25Z

It seems to get enabled via set build trigger to SCM poll.
Source:
https://stackoverflow.com/a/37742811

I used this pipeline script which do this automatically if build is triggered manually.

pipeline {
    agent any
    
    triggers {
        pollSCM('H * * * *')
    }
   // remaining pipeline code ...

}

adelcast force-pushed the dev/adelcast/add_pipeline_support branch from 022b57e to dab320b Compare September 22, 2017 21:52

adelcast changed the title ~~Dev/adelcast/add pipeline support~~ tfs: add pipeline support Sep 22, 2017

adelcast changed the title ~~tfs: add pipeline support~~ add pipeline support Sep 22, 2017

yacaovsnc requested review from olivierdagenais and removed request for olivierdagenais September 26, 2017 18:13

jpricket reviewed Sep 27, 2017

View reviewed changes

jpricket requested changes Sep 27, 2017

View reviewed changes

adelcast force-pushed the dev/adelcast/add_pipeline_support branch from dab320b to c2ae166 Compare September 28, 2017 22:39

adelcast force-pushed the dev/adelcast/add_pipeline_support branch from c2ae166 to eab95c6 Compare October 9, 2017 22:15

jpricket approved these changes Oct 10, 2017

View reviewed changes

adelcast force-pushed the dev/adelcast/add_pipeline_support branch 2 times, most recently from baba450 to f585335 Compare October 16, 2017 21:43

adelcast force-pushed the dev/adelcast/add_pipeline_support branch from f585335 to 63fa9b1 Compare October 17, 2017 16:50

Alejandro del Castillo added 3 commits October 27, 2017 11:33

pom.xml: update plugin dependency to 2.29

66bd826

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

Testing.md: add COMPUTERNAME env variable dependency

df74dad

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

tfs: add pipeline support

347da08

Follow the guide on https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md. Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

adelcast force-pushed the dev/adelcast/add_pipeline_support branch from 63fa9b1 to 347da08 Compare October 27, 2017 16:35

jpricket closed this Nov 2, 2017

jpricket reopened this Nov 2, 2017

jpricket merged commit 21632ef into jenkinsci:master Nov 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add pipeline support #176

add pipeline support #176

adelcast commented Sep 22, 2017

jpricket Sep 27, 2017

mosabua Sep 28, 2017

adelcast Sep 28, 2017

jpricket Sep 27, 2017

adelcast Sep 28, 2017

jpricket Sep 27, 2017

adelcast Sep 28, 2017

jpricket Sep 27, 2017

adelcast Sep 28, 2017

jpricket left a comment

kvarec commented Oct 9, 2017

adelcast commented Oct 9, 2017

jpricket left a comment

kvarec commented Oct 12, 2017 •

edited

Loading

adelcast commented Oct 16, 2017

kvarec commented Oct 17, 2017 •

edited

Loading

adelcast commented Oct 17, 2017

cdenneen commented Oct 26, 2017

jpricket commented Oct 26, 2017

cdenneen commented Oct 26, 2017

adelcast commented Oct 27, 2017

adelcast commented Oct 27, 2017

fuzzmz commented Nov 2, 2017

jpricket commented Nov 2, 2017

jpricket commented Nov 2, 2017

calmzhu commented Jan 21, 2018 •

edited

Loading

jpricket commented Jan 21, 2018

Tetradeus commented Jun 8, 2018

raulney commented Jan 15, 2019

Tetradeus commented Jan 15, 2019

trivalik commented Sep 25, 2020

		@@ -19,16 +21,26 @@

		private final List<ChangeSet> changesets;

		@Deprecated

add pipeline support #176

add pipeline support #176

Conversation

adelcast commented Sep 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpricket left a comment

Choose a reason for hiding this comment

kvarec commented Oct 9, 2017

adelcast commented Oct 9, 2017

jpricket left a comment

Choose a reason for hiding this comment

kvarec commented Oct 12, 2017 • edited Loading

adelcast commented Oct 16, 2017

kvarec commented Oct 17, 2017 • edited Loading

adelcast commented Oct 17, 2017

cdenneen commented Oct 26, 2017

jpricket commented Oct 26, 2017

cdenneen commented Oct 26, 2017

adelcast commented Oct 27, 2017

adelcast commented Oct 27, 2017

fuzzmz commented Nov 2, 2017

jpricket commented Nov 2, 2017

jpricket commented Nov 2, 2017

calmzhu commented Jan 21, 2018 • edited Loading

jpricket commented Jan 21, 2018

Tetradeus commented Jun 8, 2018

raulney commented Jan 15, 2019

Tetradeus commented Jan 15, 2019

trivalik commented Sep 25, 2020

kvarec commented Oct 12, 2017 •

edited

Loading

kvarec commented Oct 17, 2017 •

edited

Loading

calmzhu commented Jan 21, 2018 •

edited

Loading