Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES JENKINS-18434 - Added validation error to Parameterized build choice, removed hard error. #968

Merged
merged 4 commits into from
Oct 8, 2013

Conversation

akiellor
Copy link
Contributor

@akiellor akiellor commented Oct 7, 2013

NOTE: Jenkins currently ignores form validation errors for all fields when changing job configuration. So job configuration can be saved in an erroneous state. The errors are retained when the configure page is revisited.

@cloudbees-pull-request-builder

core » jenkins_main_trunk #1302 SUCCESS
This pull request looks good

@olivergondza
Copy link
Member

The change seems right to me. Just move the doCheckChoices method to ChoiceParameterDefinition.DescriptorImpl where it belongs.

@cloudbees-pull-request-builder

core » jenkins_main_trunk #1309 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

core » jenkins_main_trunk #1310 UNSTABLE
Looks like there's a problem with this pull request

@olivergondza olivergondza merged commit c4e2e59 into jenkinsci:master Oct 8, 2013
@olivergondza
Copy link
Member

Thanks for contributing.

olivergondza added a commit that referenced this pull request Oct 8, 2013
@akiellor akiellor deleted the JENKINS-18434 branch July 20, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants