Update dependency libpgs to v0.8.1 #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
|
nyanmisaka
approved these changes
Nov 7, 2024
thornbill
added
bug
thornbill
approved these changes
Nov 7, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 19, 2024
Update dependency libpgs to v0.8.1 Original-merge: 133273a Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the second PR on this.
Changes
This PR updates the libpgs dependency to fix an issue where subtitles aren't cleared when drawn outside of the subtitle window. The change ensures the exact drawing area is cleared and ignoring the window.
Issues
Fixes Arcus92/libpgs-js#18