Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency libpgs to v0.8.0 #6291

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Update dependency libpgs to v0.8.0 #6291

merged 1 commit into from
Nov 4, 2024

Conversation

Arcus92
Copy link
Contributor

@Arcus92 Arcus92 commented Nov 3, 2024 •
edited
Loading

Changes
This PR updates libpgs-js to version v0.8.0:

  • Fixed a subtitle position issue (see 10.10.0 Experimental PGS subtitle render alignment #6273). The subtitle position now matches the position in FFmpeg.
  • Custom video aspect ratios (stretch, cover) are now respected by the subtitle canvas.
  • Subtitle cropping is now supported. This is based on the FFmpeg implementation, but I couldn't test it on a real subtitle track yet.

Issues
Fixes #6273

@Arcus92 Arcus92 requested a review from a team as a code owner November 3, 2024 11:19
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 3, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 1ab22fc
Status ✅ Deployed!
Preview URL https://b83fcf0e.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@nyanmisaka
Copy link
Member

If you want this fix to go into 10.10.1, retarget the release-10.10.z branch.

See also https://github.com/jellyfin/jellyfin-web/pulls?q=is%3Apr+is%3Aclosed+label%3A%22stable+backport%22

@Arcus92 Arcus92 changed the base branch from master to release-10.10.z November 3, 2024 11:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nyanmisaka
Copy link
Member

@thornbill Will this fix make it to 10.10.1 or wait for 10.10.2? It fixes an issue in the experimental PGS rendering.

@thornbill
Copy link
Member

It missed 10.10.1. We will have to get it in the next one.

@thornbill thornbill added bug Something isn't working stable backport Backport into the next stable release labels Nov 3, 2024
@thornbill thornbill added this to the v10.10.2 milestone Nov 3, 2024
@thornbill thornbill merged commit 22ae941 into jellyfin:release-10.10.z Nov 4, 2024
14 checks passed
@Arcus92 Arcus92 mentioned this pull request Nov 5, 2024
Closed
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Nov 19, 2024
joshuaboniface pushed a commit that referenced this pull request Nov 19, 2024
@Arcus92 @joshuaboniface
Backport pull request #6291 from jellyfin-web/release-10.10.z
c3d7401 
Update dependency libpgs to v0.8.0

Original-merge: 22ae941

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
kevgrig pushed a commit to kevgrig/jellyfin-web that referenced this pull request Jan 7, 2025
@Arcus92 @kevgrig
Backport pull request jellyfin#6291 from jellyfin-web/release-10.10.z
cb5f550 
Update dependency libpgs to v0.8.0

Original-merge: 22ae941

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.2
Development

Successfully merging this pull request may close these issues.

10.10.0 Experimental PGS subtitle render alignment
4 participants
@Arcus92 @jellyfin-bot @nyanmisaka @thornbill