Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use strict mode for view manager pages #6223

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

thornbill
Copy link
Member

Changes
Reverts the hack to prevent duplicate effect calls in strict mode. Selectively applies strict mode so it does not impact legacy view manager pages.

Issues
#6205 (comment)

@thornbill thornbill added bug Something isn't working regression We broke something labels Oct 19, 2024
@thornbill thornbill added this to the v10.10.0 milestone Oct 19, 2024
@thornbill thornbill requested a review from a team as a code owner October 19, 2024 05:52
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 19, 2024

Cloudflare Pages deployment

Latest commit 7abe027
Status ✅ Deployed!
Preview URL https://fcce7a8f.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@thornbill thornbill changed the title Strict mode strikes again Do not use strict mode for view manager pages Oct 19, 2024
Copy link

@thornbill thornbill merged commit a8715d0 into jellyfin:master Oct 19, 2024
14 checks passed
@thornbill thornbill deleted the strict-mode-strikes-again branch October 19, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants