Add examples to LabelPublishedServerUriHelp string #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Changes should only be made to the en-us localization file. All other translations are managed in our weblate instance.
thornbill
added
enhancement
thornbill
reviewed
Oct 9, 2024
src/strings/en-us.json
Outdated
| @@ -837,7 +837,7 @@ | |||
| "LabelPublicHttpsPort": "Public HTTPS port number", | |||
| "LabelPublicHttpsPortHelp": "The public port number that should be mapped to the local HTTPS port.", | |||
| "LabelPublishedServerUri": "Published Server URIs", | |||
| "LabelPublishedServerUriHelp": "Override the URI used by Jellyfin, based on the interface, or client IP address.", | |||
| "LabelPublishedServerUriHelp": "Override the URI used by Jellyfin, based on the interface, or client IP address. For example: internal=http://jellyin.example.com, or external=https://jellyfin.example.com, or all=https://jellyfin.example.com", | |||
There was a problem hiding this comment.
Suggested change
| "LabelPublishedServerUriHelp": "Override the URI used by Jellyfin, based on the interface, or client IP address. For example: internal=http://jellyin.example.com, or external=https://jellyfin.example.com, or all=https://jellyfin.example.com", | |
| "LabelPublishedServerUriHelp": "Override the URI used by Jellyfin, based on the interface, or client IP address. For example: internal=http://jellyin.example.com, external=https://jellyfin.example.com, or all=https://jellyfin.example.com", |
scottmckenzie
force-pushed
the
add-published-server-uri-examples
branch
from
101f825 to
b94c037
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some examples to the English help text for the Published Server URIs setting.