-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HEVC playback on Hisense Vidaa OS #6135
Conversation
Both models claim to support HEVC. 🤷♂️ Could it be a weird encoding of the file? |
MKV + DirectPlay in a web browser? VIDAA's documentation says they require ISO BMFF (MPEG4). @abdulmueid Maybe you should remux your video to an MP4 container and try again. |
@dmitrylyzo Exactly, they both do support HEVC. When playing the same files off a USB drive, they play fine. But when in a browser, they glitch out. My content is mostly HEVC 10-bit at 1080p or 4K in MKV containers. Ultimately, for the user-experience, I think it should work without requiring any remuxing or additional steps. In my case, the best scenario is to transcode on-the-fly. If Jellyfin allowed force transcoding without dropping the bitrate to below native, this whole PR would not be needed. |
If MP4 works fine, then we just need to explicitly disable MKV Direct Play for |
Found a related issue for remuxing/transcoding: Just posting here for reference. |
|
Cloudflare Pages deployment
|
I did the following:
The video fails to play, however, in the logs I see that FFMpeg is remuxing with errors. Here is the log: I see a number of errors like I did not understand the bit about adding to supported list. The line you pointed out disables mp4Hls if it's not natively supported on safari, webOs and tizen. I changed the line regardless to test and it had no effect. Unless i'm missing something, i'd be happy for feedback. Any ideas where to go from here? Personally I am happy to disable mkv support and use transcoding for hevc playback without fmp4 remuxing. |
Quick update: hlsInTs works well when disabling MKV. So the only two changes required are:
There is no need to enable hlsInFmp4. Branch updated. Please review and suggest any other required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Many TVs prefer HEVC in MPEG-TS over fMP4, and it looks like browser.vidaa
is no exception.
It is better to change the PR name to "Fix smth on smth" and squash commits into one before merging. Also, you don't need to rebase to the latest branch unless there are merge conflicts.
@nyanmisaka thanks for the go-ahead. I have renamed the PR and squashed commits. |
ccb0fb5
to
b12ff2a
Compare
There is nothing I can do here. You need to wait for the web team to approve and merge. |
…. Tested on 2 models (U7 & U8). This commit disables HEVC on Vidaa OS browser profile and uses transcoding instead to play HEVC files. With MKV disabled and hlsInTs, hevc videos work properly by remuxing on Hisense Vidaa OS. Tested on model 55U7QF. Removed force disabling hevc as it is no longer required with hlsInTs
b12ff2a
to
316542c
Compare
Quality Gate passedIssues Measures |
Vidaa OS web browser reports it supports HEVC but playback is extremely glitchy (See links below).
Tested on 2 models (Hisense U7 & U8). This commit disables HEVC on Vidaa OS browser profile to stop HEVC Direct Play and allows transcoding HEVC files without resorting to very low bitrates to trigger transcoding.
Before
After
Without this fix, only way to play videos on Hisense TVs with Vidaa OS is to set the bitrate below the video's native bitrate to trigger transcoding which often takes the video in to 480p and below territory and is not watchable.
Changes
Changed the canPlayHevc(...) function in browserDeviceProfile to return false when it detects browser.vidaa
This essentially tells rest of the Jellyfin-web client that Vidaa does not support HEVC, therefore allowing transcoding at native video resolution.
Issues