Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dolby Vision fallback layer on Tizen 3+ #6090

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Sep 20, 2024

Changes
Allow Dolby Vision fallback layer on Tizen 3+.

Issues
N/A

@dmitrylyzo dmitrylyzo added p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback labels Sep 20, 2024
@dmitrylyzo dmitrylyzo added this to the v10.10.0 milestone Sep 20, 2024
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner September 20, 2024 00:14
@gnattu
Copy link
Member

gnattu commented Sep 20, 2024

Does directstream/remux still work for dolby vision in this case? Just adding profile 8 will cause ffmpeg to tag the video with dvh1 fourcc instead of dvh1 fourcc. If Tizen can handle fallback even in this case then this would be safe enough, otherwise we have to find a way to only add those for direct play, but remove those for remux and direct stream.

@dmitrylyzo
Copy link
Contributor Author

dmitrylyzo commented Sep 20, 2024

Does directstream/remux still work for dolby vision in this case? Just adding profile 8 will cause ffmpeg to tag the video with dvh1 fourcc instead of dvh1 fourcc. If Tizen can handle fallback even in this case then this would be safe enough, otherwise we have to find a way to only add those for direct play, but remove those for remux and direct stream.

Retested with "Stereo only": Direct streaming, playing fine.
Also, remuxed to MKV - also playing fine.

The only thing: on LT27H390 (Tizen 3) the colors are more "yellowish", on UE65NU7400 (Tizen 4) they are "reddish". I was testing P81_GlassBlowing2_1920x1080%4059.94fps_15200kbps_fmp4 sample. "Reddish" are looking better/natural, imo.

🤦‍♂️ LT27H390 (Tizen 3) isn't HDR Ready. This can be fixed on the app side.

Question. Can we just do this?

    let hevcVideoRangeTypes = 'SDR|DOVIWithSDR';
    let vp9VideoRangeTypes = 'SDR';
    let av1VideoRangeTypes = 'SDR';

    if (supportsHdr10(options)) {
        hevcVideoRangeTypes += '|HDR10|DOVIWithHDR10';
        vp9VideoRangeTypes += '|HDR10';
        av1VideoRangeTypes += '|HDR10';
    }

    if (supportsHlg(options)) {
        hevcVideoRangeTypes += '|HLG|DOVIWithHLG';
        vp9VideoRangeTypes += '|HLG';
        av1VideoRangeTypes += '|HLG';
    }

Or do we still have to support some DoVi data?

@gnattu
Copy link
Member

gnattu commented Sep 20, 2024

Question. Can we just do this?

If only for Tizen then yes, for other devices no because not all devices accepts the dvh1 fourcc tagged by ffmpeg and will not play the fallback layer at all, which means ffmpeg needs to tag it with hvc1 so that the device can play the HDR10/HLG fallback layer.

@dmitrylyzo dmitrylyzo changed the title Allow Dolby Vision Profile 8 on Tizen 3+ Allow Dolby Vision fallback layer on Tizen 3+ Sep 20, 2024
Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit aa4004a1befb7ebc71e1a21e725446e6b2149e95
Status ✅ Deployed!
Preview URL https://e0e48c6a.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 0c729d3 into jellyfin:master Sep 21, 2024
12 checks passed
@dmitrylyzo dmitrylyzo deleted the tizen-dovi branch September 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants