Discard chrome and safari on Tizen and webOS
#6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
|
Cloudflare Pages deployment
|
The problem is that we don't know the actual transcoding codec until the client loads the HLS stream and play it and we need a player to load HLS first. |
thornbill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We consider
safarito be an actual Safari browser andchrometo be an actual Chrome browser.Tizen and webOS may be "Safari" (WebKit) or "Chrome", but their capabilities are different from Safari and Chrome.
When testing #6073 webOS 1.2 (WebKit) tried to play TS+H264 using HLS.js.
Here we should check the transcoding codec, but we check the codec of the original media source:
jellyfin-web/src/components/htmlMediaHelper.js
Line 35 in e5df4dd
Although the use of HLS.js is caused by another bug, the mentioned inconsistency can cause problems when generating a device profile.
Changes
Discard
chromeandsafarion Tizen and webOS.Issues
N/A
Alternatively, we could add
&& !browser.web0s && !browser.tizeneverywhere, but that's too wordy.Notes
Chromecast will be disabled on Tizen and webOS.
jellyfin-web/src/index.jsx
Lines 150 to 152 in 0ae080a