Make hotkeys strict and prevent default actions for handled ones #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
enhancement
|
Cloudflare Pages deployment
|
dmitrylyzo
changed the title
thornbill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit dirty fix. We should probably migrate to
hotkeys-jsor similar later.I cherry-picked and squashed the commits from #5046, which is currently the
masterbranch. I also rearranged these changes to make them smaller.I didn't ignore modifiers in
Emby*elements. In particular, inEmbySlider, because otherwise the browser started dragging the slider by itself.I didn't ignore modifiers for
SpaceandEnterbecause the latter seem to work ignoring them.Changes
Shift+,Alt+,Ctrl+,Meta+).keydownto get actual modifiers.Issues
Fixes #4908
Closes #5046
Fixes #5457