Fix double click to uncheck in multi-select menu #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed the bug was present and tested the fix branch to verify that the changes fixed the bug. Deselecting the initial item now only requires one click as expected. |
viown
force-pushed
the
fix-double-select
branch
from
090265e to
79e4cf1
Compare
thornbill
force-pushed
the
fix-double-select
branch
from
79e4cf1 to
b5a252e
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection panels have a "checkedInitial" class which is used to prevent an immediate check and uncheck when long pressing a card element. This class will still be there when clicking on 3 dots -> select, resulting in the user having to click twice to uncheck the initial element.
Changes
Add an argument to only add this class when long pressing.
Issues
Fixes #6025