Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly strict dovi level testing #5983

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix overly strict dovi level testing #5983

merged 1 commit into from
Sep 3, 2024

Conversation

nyanmisaka
Copy link
Member

4k@60fps is usually only seen in demos so it's a bit overkill for testing dovi caps. Lower it to the more common 4k@24fps.

Ref: https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby-vision-streams-within-the-http-live-streaming-format-v2.0-13-november-2018.pdf

Changes

  • Fix overly strict dovi level testing

Issues

  • iPad Pro 2018 only reports up to 4k30 dovi support after upgrading to iPadOS 17, but can actually play 4k60 normally and it used to report 4k60 on older systems.

@nyanmisaka
Fix overly strict dovi level testing
b1a6fd5 
4k@60fps is usually only seen in demos so it's a bit overkill
for testing dovi caps. Lower it to the more common 4k@24fps.

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
@nyanmisaka nyanmisaka requested a review from a team as a code owner August 28, 2024 16:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dmitrylyzo dmitrylyzo added enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback labels Aug 28, 2024
@dmitrylyzo dmitrylyzo added this to the v10.9.11 milestone Aug 28, 2024
gnattu
gnattu approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@gnattu gnattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was facing some bugs that in rare case the DOVI mode is not triggered and Profile 5 60fps videos are rendered in wrong color, but I cannot reliably reproduce it now. Probably this is the quirk but let's only test for 24fps for now.

BTW, if someone has iPad Pro 2024 with M4 chip I'd like to get the report of Dolby Vision Profile 10 playback testing results. It is rumored to support dav1.10.09 but I'm not verified that yet.

@nyanmisaka
Copy link
Member Author

nyanmisaka commented Aug 28, 2024 •
edited
Loading

Actually I was facing some bugs that in rare case the DOVI mode is not triggered and Profile 5 60fps videos are rendered in wrong color, but I cannot reliably reproduce it now. Probably this is the quirk but let's only test for 24fps for now.

I can't imagine a device that supports Dolby Vision but doesn't support 4k60 playback.

BTW, if someone has iPad Pro 2024 with M4 chip I'd like to get the report of Dolby Vision Profile 10 playback testing results. It is rumored to support dav1.10.09 but I'm not verified that yet.

dav1 is already in the documentation. https://developer.apple.com/documentation/http-live-streaming/hls-authoring-specification-for-apple-devices-appendixes#The-SUPPLEMENTAL-CODECS-attribute

Tested that jellyfin-ffmpeg7 can tonemap and remux dav1. It seems that no player yet is capable of this fourcc, software decoders always expect av01.

I'm not sure to what extent SUPPLEMENTAL-CODECS plays a role. But not having it did not stop us from playing DoVi.

@thornbill thornbill added the stable backport Backport into the next stable release label Sep 3, 2024
@thornbill thornbill merged commit 2ebf0c9 into jellyfin:release-10.9.z Sep 3, 2024
9 checks passed
@nyanmisaka nyanmisaka deleted the fix-dovi-level-test branch September 3, 2024 15:26
joshuaboniface pushed a commit that referenced this pull request Sep 7, 2024
@nyanmisaka @joshuaboniface
Backport pull request #5983 from jellyfin-web/release-10.9.z
5eb91ea 
Fix overly strict dovi level testing

Original-merge: 2ebf0c9

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnattu gnattu gnattu approved these changes

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.11
Development

Successfully merging this pull request may close these issues.
5 participants
@nyanmisaka @thornbill @gnattu @jellyfin-bot @dmitrylyzo