Fix redirect after deleting item #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirects to the parent of an item instead of homepage after deleting the item
|
This context menu is used all over the place and in most cases this would not be the desired behavior. i.e. Deleting an item on the home page. |
I see, so what changes would you propose then? |
|
Looks like it would be better to just change the behavior here: https://github.com/jellyfin/jellyfin-web/blob/master/src/controllers/itemDetails/index.js#L2024 |
This reverts commit 6e36915.
Redirects to the parent of an item instead of homepage after deleting the item
|
I moved the logic there, would you say it's ok now? @thornbill |
|
Cloudflare Pages deployment
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deleting an item (episode, season, ..) will now redirect to the parent of that item instead of redirecting to homepage.
I wonder why is this behavior disabled in the first place and why it hasn't been changed/looked at in almost 8 years,
since it was added (ef8dbee). Or am I missing something?
Issues
Fixes #1038