Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect initial play icon in remote control section #5915

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix incorrect initial play icon in remote control section #5915

merged 1 commit into from
Aug 16, 2024

Conversation

viown
Copy link
Member

@viown viown commented Aug 15, 2024

The play icon buttons in the remote control section would incorrectly display the pause icon when the media was paused until the session gets updated.

Changes
Swap out the play arrow and pause icons in the initial state.

Issues
Fixes #5874

@viown viown requested a review from a team as a code owner August 15, 2024 20:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dmitrylyzo
dmitrylyzo approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

jellyfin-web/src/controllers/dashboard/dashboard.js

Line 580 in 76a28e1

btnSessionPlayPauseIcon.classList.add(session.PlayState?.IsPaused ? 'play_arrow' : 'pause');

@dmitrylyzo dmitrylyzo added bug Something isn't working ui & ux This PR or issue mainly concerns UI & UX labels Aug 15, 2024
@dmitrylyzo dmitrylyzo added this to the v10.9.10 milestone Aug 15, 2024
@thornbill thornbill added the stable backport Backport into the next stable release label Aug 16, 2024
@thornbill thornbill merged commit 8bc9544 into jellyfin:release-10.9.z Aug 16, 2024
9 checks passed
joshuaboniface pushed a commit that referenced this pull request Aug 25, 2024
@viown @joshuaboniface
Backport pull request #5915 from jellyfin-web/release-10.9.z
9a3cba0 
Fix incorrect initial play icon in remote control section

Original-merge: 8bc9544

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Aug 25, 2024
@viown viown deleted the fix-paused-state branch August 29, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui & ux This PR or issue mainly concerns UI & UX
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.10
Development

Successfully merging this pull request may close these issues.
4 participants
@viown @dmitrylyzo @thornbill @jellyfin-bot