Fix "Download All" for Safari #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
thornbill
reviewed
Aug 13, 2024
Added check to use fallback downloader for iOS Added check for safari to use the delayed download function Remove old comment about firefox, as a.click() supported since Firefox 75 (2020) Fixes: jellyfin#5672
Instead of conditionally using setTimeout based on browser, we should always use it since it sometimes also misses some episodes.
thornbill
force-pushed
the
fix-download-all-10.9
branch
from
8dc853d to
9354f1f
Compare
|
thornbill
approved these changes
Aug 13, 2024
thornbill
pushed a commit
that referenced
this pull request
Aug 13, 2024
Fix "Download All" for Safari Original-merge: 4071c44 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: thornbill <thornbill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added check to use fallback downloader for iOS
Changed download to always use
setTimeoutinstead of conditionally on browser.Remove old comment about firefox, as
a.click()supported since Firefox 75 (2020) refIssues
Fixes #5672
Related #5744 (reopened against 10.9)