Replace history syncing with RouterHistory #5825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
|
This was referenced Jul 25, 2024
|
Preview URL: https://44f001e6.jellyfin-web.pages.dev/ |
|
Did a bunch of navigation, playing items, opening menus/overlays, going to dashboard and back. Both on the unstable demo and my stable server. Overall everything feels fine, found two issues that I could also reproduce in 10.9.8, so most likely not related to this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RouterHistoryas an implementation of theHistoryinterface backed by the underlying react-router instance. This replaces the history syncing implementation that causes history actions to be invalid and/or duplicated (everything registers as aREPLACE).#!url formatWhat needs testing?
#!Issues
Related to #5656 (fixes the incorrect and duplicate history events that prevents us from reverting the caching behavior) (will require additional changes to fully fix)