Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lazy routes everywhere #5802

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Use lazy routes everywhere #5802

merged 2 commits into from
Jul 17, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Unify Root and Stable routers moving all experimental layout checks to RootAppRouter
  • Use lazy routes for layout imports
  • Fix home page crash when using lazy due to direct import of libraryMenu and mainTabsManager (they depend on DOM elements existing when imported)
  • Remove @loadable/component dependency

Issues
N/A

@thornbill thornbill added enhancement Improve existing functionality or small fixes cleanup Cleanup of legacy code or code smells labels Jul 16, 2024
@thornbill thornbill added this to the v10.10.0 milestone Jul 16, 2024
@thornbill thornbill requested a review from a team as a code owner July 16, 2024 21:31
@thornbill thornbill changed the title Router cleanup Use lazy routes everywhere Jul 17, 2024
@thornbill thornbill merged commit 277bb16 into jellyfin:master Jul 17, 2024
8 checks passed
@thornbill thornbill deleted the router-cleanup branch July 17, 2024 19:11
@thornbill thornbill mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thornbill @nielsvanvelzen