Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change volume if it is physically controlled #5740

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Don't change volume if it is physically controlled #5740

merged 1 commit into from
Jul 10, 2024

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Jun 27, 2024 •
edited
Loading

LG remote has a wheel, so after #4435 the volume can be changed with it, but it is not expected and there is no indication.

Changes
Don't change volume if it is physically controlled.

Issues
Fixes jellyfin/jellyfin-webos#233

@dmitrylyzo dmitrylyzo added bug Something isn't working regression We broke something stable backport Backport into the next stable release p: webos This PR or issue mainly concerns WebOS clients playback This PR or issue mainly concerns playback labels Jun 27, 2024
@dmitrylyzo dmitrylyzo added this to the v10.9.8 milestone Jun 27, 2024
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner June 27, 2024 10:20
@thornbill thornbill merged commit e0a0c92 into jellyfin:release-10.9.z Jul 10, 2024
8 checks passed
@dmitrylyzo dmitrylyzo deleted the fix-tv-volume branch July 15, 2024 12:33
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jul 21, 2024
joshuaboniface pushed a commit that referenced this pull request Jul 21, 2024
@dmitrylyzo @thornbill
Backport pull request #5740 from jellyfin-web/release-10.9.z
59db692 
Don't change volume if it is physically controlled

Original-merge: e0a0c92

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Bill Thornton <thornbill@users.noreply.github.com>
@dmitrylyzo dmitrylyzo mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working p: webos This PR or issue mainly concerns WebOS clients playback This PR or issue mainly concerns playback regression We broke something
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.8
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrylyzo @thornbill @jellyfin-bot