Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor activity page to use react query requests #5727

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

bu3alwa
Copy link
Contributor

@bu3alwa bu3alwa commented Jun 24, 2024

I thought there was a bug here but turns out I was on an older version of MUI but since I was investigating it I ended up refactoring it to use react query.

@bu3alwa bu3alwa marked this pull request as ready for review June 24, 2024 14:52
@bu3alwa bu3alwa requested a review from a team as a code owner June 24, 2024 14:52
@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Jul 11, 2024
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch from 2af1c96 to 1bfae71 Compare August 15, 2024 03:24
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 15, 2024
@jellyfin-bot

This comment has been minimized.

@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch from 1bfae71 to 4828940 Compare August 15, 2024 03:29
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Aug 15, 2024
@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch from 4828940 to 23bb607 Compare August 15, 2024 03:32
@bu3alwa bu3alwa requested a review from grafixeyehero August 15, 2024 03:35
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
src/hooks/useGetLogEntries.tsx Outdated Show resolved Hide resolved
src/hooks/useGetLogEntries.tsx Outdated Show resolved Hide resolved
src/hooks/useGetLogEntries.tsx Outdated Show resolved Hide resolved
src/hooks/useGetUsers.tsx Outdated Show resolved Hide resolved
@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch 2 times, most recently from a53e4f9 to 2b7b253 Compare August 21, 2024 00:54
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 21, 2024
@jellyfin-bot

This comment was marked as outdated.

@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch from 2b7b253 to e36f57c Compare August 21, 2024 00:58
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Aug 21, 2024
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
@bu3alwa bu3alwa force-pushed the refactor-activity-dashboard branch from e36f57c to 710fe64 Compare August 21, 2024 23:24
Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 710fe641e2a5864125bf8875c17e351d15da5000
Status ✅ Deployed!
Preview URL https://92c21f35.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill changed the title refactor activity page to use react query requests Refactor activity page to use react query requests Aug 23, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 23, 2024
@thornbill thornbill merged commit 6b4ad37 into jellyfin:master Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants