Fix Trickplay thumbnail in older web engines #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In webOS 1.2, the image is scaled to fit in the `chapterThumpWrapper` and ignores position. Since it doesn't seem to support `resize` nor `object-fit` to prevent scaling, use background instead.
dmitrylyzo
added
bug
dmitrylyzo
changed the title
thornbill
approved these changes
Jul 15, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Jul 21, 2024
Fix Trickplay thumbnail in older web engines Original-merge: 9501c50 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Bill Thornton <thornbill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace image with CSS
background.Issues
In webOS 1.2, the image is scaled to fit in the
chapterThumpWrapperand ignores position. Since it doesn't seem to supportresizenorobject-fitto prevent scaling, use background instead.I avoided reusing
chapterThumbwith necessary CSS changes since it is used by chapters.