Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force DoVi on browser.xboxOne as edgeUWP says it can't play it #5669

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Force DoVi on browser.xboxOne as edgeUWP says it can't play it #5669

merged 1 commit into from
Jul 26, 2024

Conversation

RaafatAkkad
Copy link
Contributor

@RaafatAkkad RaafatAkkad commented Jun 6, 2024 •
edited
Loading

Unsure if DoVi can be used with profile 8 on Xbox but video play

https://ott.dolby.com/codec_test/index.html
Screenshot 2024-06-10 at 8 50 16 PM

@RaafatAkkad RaafatAkkad requested a review from a team as a code owner June 6, 2024 18:35
@RaafatAkkad RaafatAkkad mentioned this pull request Jun 6, 2024
Draft
@RaafatAkkad
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Unrelated to my change

@RaafatAkkad RaafatAkkad mentioned this pull request Jun 6, 2024
Open
@thornbill thornbill added enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback labels Jun 10, 2024
@RaafatAkkad
Force DoVi on browser.xboxOne as edgeUWP says it can't play it
cb085ff 
Unsure if DoVi profile 8 works on Xbox but the video plays
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@thornbill thornbill merged commit 665678d into jellyfin:release-10.9.z Jul 26, 2024
3 checks passed
@thornbill thornbill added this to the v10.10.0 milestone Jul 26, 2024
@thornbill thornbill modified the milestones: v10.10.0, v10.9.9 Aug 5, 2024
@thornbill thornbill added p:xbox This PR or issue mainly concerns Xbox clients stable backport Backport into the next stable release labels Aug 5, 2024
thornbill pushed a commit that referenced this pull request Aug 5, 2024
@RaafatAkkad @thornbill
Backport pull request #5669 from jellyfin-web/release-10.9.z
fa3be55 
Force DoVi on browser.xboxOne as edgeUWP says it can't play it

Original-merge: 665678d

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: thornbill <thornbill@users.noreply.github.com>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Aug 5, 2024
@RaafatAkkad
Copy link
Contributor Author

RaafatAkkad commented Aug 5, 2024 •
edited
Loading

Thanks @thornbill
Until options.supportsDolbyVision returns true (when jellyfin/jellyfin-uwp#46 is merged), that code path will not be executed.

Given that jellyfin 10.9 has been out for a while, I'm going to retarget #5628 to master and this can be enabled to the next major release.

@RaafatAkkad RaafatAkkad deleted the patch-2 branch August 5, 2024 18:58
@TroubleDog54 TroubleDog54 mentioned this pull request Aug 13, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes p:xbox This PR or issue mainly concerns Xbox clients playback This PR or issue mainly concerns playback
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.9
Development

Successfully merging this pull request may close these issues.
3 participants
@RaafatAkkad @thornbill @jellyfin-bot