Add lyrics auto scroll #5585
Merged
Add lyrics auto scroll #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe worth a PR against 10.9? IMHO it's a bit weird behaviour to not scroll on timed lyrics |
scampower3
force-pushed
the
lyrics-auto-scroll
branch
from
f0dab2b to
904b8bf
Compare
|
Yeah, I agree. Changed the base to 10.9.z |
dmitrylyzo
reviewed
May 22, 2024
dmitrylyzo
reviewed
May 22, 2024
scampower3
force-pushed
the
lyrics-auto-scroll
branch
from
7fed6fe to
fa9b0e6
Compare
This comment has been minimized.
This comment has been minimized.
dmitrylyzo
reviewed
May 23, 2024
dmitrylyzo
reviewed
May 23, 2024
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
dmitrylyzo
reviewed
May 24, 2024
There was a problem hiding this comment.
Desktop and Mobile display modes work fine.
In TV display mode, this autoFocuser call breaks the instant scroll to the current lyric.
jellyfin-web/src/controllers/lyrics.js
Line 142 in 15e35fa
Called after
scrollToElement, selecting the first lyric.
We could try replacing it with focusing the current lyrics (using focusManager).
1 task
thornbill
added
feature
thornbill
reviewed
Jun 9, 2024
|
thornbill
reviewed
Jun 9, 2024
dmitrylyzo
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds autoscrolling to lyrics. Will stop autoscrolling if wheel or up key or down key is used. Can continue autoscrolling by selecting the lyrics line.
Issues
Fixes #5487