Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search for tab library in experimental layout #5571

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix search for tab library in experimental layout #5571

merged 2 commits into from
Jul 15, 2024

Conversation

grafixeyehero
Copy link
Member

@grafixeyehero grafixeyehero commented May 20, 2024 •
edited
Loading

Changes

  • Extract Search Button to component
  • Fix Search for tab library based on url params parentId and collectionType
  • Disable the SearchButton in the AppToolbar if the current location is the Search page.

@grafixeyehero grafixeyehero requested a review from a team as a code owner May 20, 2024 21:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@grafixeyehero grafixeyehero added the enhancement Improve existing functionality or small fixes label May 20, 2024
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 4fe0ec6
Status ✅ Deployed!
Preview URL https://a3e3ed02.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill changed the title Fix: Search for tab library in experimental layout Fix search for tab library in experimental layout Jul 11, 2024
@thornbill thornbill force-pushed the Fix--Search-for-tab-library branch from 4fe0ec6 to 9d62d6c Compare July 11, 2024 05:08
grafixeyehero and others added 2 commits July 15, 2024 20:09
@grafixeyehero
Fix: Search for tab library
69afc01
@grafixeyehero @thornbill
apply suggestion
f8cb872 
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
@grafixeyehero grafixeyehero force-pushed the Fix--Search-for-tab-library branch from 9d62d6c to f8cb872 Compare July 15, 2024 17:18
@thornbill thornbill added this to the v10.10.0 milestone Jul 15, 2024
@thornbill thornbill merged commit b70f42b into jellyfin:master Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grafixeyehero @jellyfin-bot @thornbill