Add unit tests #5412

Airthee · 2024-04-23T20:37:10Z

Changes
Add unit tests to some utils files.

Issues

Fixes #4872

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/utils/card.test.ts

src/utils/dateFnsLocale.test.ts

jellyfin-bot · 2024-04-23T21:06:51Z

Cloudflare Pages deployment

Latest commit	`c7d36af`
Status	✅ Deployed!
Preview URL	https://91cc3b0d.jellyfin-web.pages.dev
Type	🔀 Preview

View build logs

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

src/utils/events.test.ts

github-actions · 2024-04-27T22:00:08Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required after '{'. object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({ type: 'testEvent'}, 'testValue1', 'testValue2');

github-actions · 2024-04-27T22:00:08Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required before '}'. object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({type: 'testEvent' }, 'testValue1', 'testValue2');

github-actions · 2024-04-27T22:00:08Z

src/utils/events.test.ts

+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');
+        });
+    })


Missing semicolon. @typescript-eslint/semi

Fix available:

Suggested change

})

});

github-actions · 2024-04-27T22:00:08Z

src/utils/events.test.ts

+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');
+        });
+    })
+})


Missing semicolon. @typescript-eslint/semi

Fix available:

Suggested change

})

});

sonarqubecloud · 2024-04-27T22:07:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions · 2024-04-27T22:08:11Z

src/utils/events.test.ts

+
+            expect(obj).toHaveProperty('_callbacks', { testEvent: [initialCallback] });
+        });
+    })


Missing semicolon. @typescript-eslint/semi

Fix available:

Suggested change

})

});

github-actions · 2024-04-27T22:08:11Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required after '{'. object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({ type: 'testEvent'}, 'testValue1', 'testValue2');

github-actions · 2024-04-27T22:08:11Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required before '}'. object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({type: 'testEvent' }, 'testValue1', 'testValue2');

thornbill · 2024-10-15T16:42:37Z

@Airthee I'm trying to clean up some stale PRs... do you plan to continue working on this?

Airthee · 2024-10-15T17:41:03Z

Hi ! Sorry I didn't work on it since many months, but I will try to fix lint and remove draft when all is green.

github-actions

ESLint doesn't pass. Please fix all ESLint issues.

github-actions · 2024-10-15T18:56:54Z

src/utils/events.test.ts

+
+            expect(obj).toHaveProperty('_callbacks', { testEvent: [initialCallback] });
+        });
+    })


Missing semicolon. @stylistic/semi

Fix available:

Suggested change

})

});

github-actions · 2024-10-15T18:56:54Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required after '{'. @stylistic/object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({ type: 'testEvent'}, 'testValue1', 'testValue2');

github-actions · 2024-10-15T18:56:55Z

src/utils/events.test.ts

+
+            eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);
+
+            expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');


A space is required before '}'. @stylistic/object-curly-spacing

Fix available:

Suggested change

expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

expect(callback).toHaveBeenCalledWith({type: 'testEvent' }, 'testValue1', 'testValue2');

sonarqubecloud · 2024-10-15T19:05:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Airthee · 2024-10-15T19:11:30Z

@thornbill I think it's all good !
If a want to add some new tests, can I refer to the same issue event if it is closed ?

thornbill · 2024-10-15T20:06:29Z

Yes, you can continue to reference the closed issue or just leave it blank. Either way is fine.

stale

Airthee added 2 commits April 23, 2024 21:00

add unit tests for Card utils

f07374d

add unit tests for DateFnsLocale utils

00f0736

Airthee force-pushed the add_unit_tests branch from cdd0672 to 11130a6 Compare April 23, 2024 20:49

github-actions bot requested changes Apr 23, 2024

View reviewed changes

fix lint

f3f652e

Airthee force-pushed the add_unit_tests branch from 11130a6 to f3f652e Compare April 23, 2024 20:56

add unit tests for Events utils

c447d8a

github-actions bot requested changes Apr 27, 2024

View reviewed changes

fix lint

afce959

github-actions bot requested changes Apr 27, 2024

View reviewed changes

Merge branch 'master' into add_unit_tests

399c48e

github-actions bot previously requested changes Oct 15, 2024

View reviewed changes

Airthee deployed to Preview October 15, 2024 18:58 — with GitHub Actions View deployment

fix lint

c7d36af

Airthee deployed to Preview October 15, 2024 19:08 — with GitHub Actions View deployment

Airthee marked this pull request as ready for review October 15, 2024 19:09

Airthee requested a review from a team as a code owner October 15, 2024 19:09

Airthee changed the title ~~draft: Add unit tests~~ Add unit tests Oct 15, 2024

thornbill approved these changes Oct 15, 2024

View reviewed changes

thornbill added the tests This PR or issue mainly concerns tests label Oct 15, 2024

thornbill added this to the v10.10.0 milestone Oct 15, 2024

thornbill merged commit a133a33 into jellyfin:master Oct 15, 2024
14 checks passed

Airthee deleted the add_unit_tests branch October 15, 2024 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests #5412

Add unit tests #5412

Airthee commented Apr 23, 2024

github-actions bot left a comment

jellyfin-bot commented Apr 23, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Apr 27, 2024

github-actions bot Apr 27, 2024

github-actions bot Apr 27, 2024

github-actions bot Apr 27, 2024

sonarqubecloud bot commented Apr 27, 2024

github-actions bot left a comment

github-actions bot Apr 27, 2024

github-actions bot Apr 27, 2024

github-actions bot Apr 27, 2024

thornbill commented Oct 15, 2024

Airthee commented Oct 15, 2024

github-actions bot left a comment

github-actions bot Oct 15, 2024

github-actions bot Oct 15, 2024

github-actions bot Oct 15, 2024

sonarqubecloud bot commented Oct 15, 2024

Airthee commented Oct 15, 2024

thornbill commented Oct 15, 2024


		eventsUtils.trigger(obj, 'testEvent', ['testValue1', 'testValue2']);

		expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');

	expect(callback).toHaveBeenCalledWith({type: 'testEvent'}, 'testValue1', 'testValue2');
	expect(callback).toHaveBeenCalledWith({ type: 'testEvent'}, 'testValue1', 'testValue2');

Add unit tests #5412

Add unit tests #5412

Conversation

Airthee commented Apr 23, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

jellyfin-bot commented Apr 23, 2024 • edited Loading

Cloudflare Pages deployment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 27, 2024

Quality Gate passed

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

github-actions bot Apr 27, 2024

Choose a reason for hiding this comment

thornbill commented Oct 15, 2024

Airthee commented Oct 15, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 15, 2024

Quality Gate passed

Airthee commented Oct 15, 2024

thornbill commented Oct 15, 2024

jellyfin-bot commented Apr 23, 2024 •

edited

Loading