Add 404 page from jekyll master
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekyllbot: merge +minor. Thanks @ashmaroli! |
jekyllbot
added a commit
that referenced
this pull request
Apr 8, 2017
domingohui
pushed a commit
to domingohui/minima
that referenced
this pull request
Apr 14, 2017
Merge pull request 121
domingohui
pushed a commit
to domingohui/minima
that referenced
this pull request
Apr 14, 2017
|
When using the minima gem with GitHub Pages, am I correct this file needs to be explicitly duplicated in the site's repo? That is, the version in the gem will not be served? |
@adamvoss Yes. This file is not part of the theme-gem. I intended it to demo the new |
antgel
pushed a commit
to antgel/minima
that referenced
this pull request
Jul 16, 2017
Merge pull request 121
antgel
pushed a commit
to antgel/minima
that referenced
this pull request
Jul 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Minima is live on Github Pages and Jekyll itself will provide this template from
v3.5, let's display the custom404.htmlinstead of using the one provided by Github