Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hamburger is displayed even if there are no site.pages #115

Closed
Adyg opened this issue Apr 5, 2017 · 2 comments
Closed

The hamburger is displayed even if there are no site.pages #115

Adyg opened this issue Apr 5, 2017 · 2 comments
Labels
frozen-due-to-age

Comments

@Adyg
Copy link
Contributor

Adyg commented Apr 5, 2017 •
edited
Loading

If there are no site.pages defined, the hamburger menu serves no purpose. Clicking it will do nothing.
Suggesting not including the nav tag at all if there are no links to populate it with.
@Adyg
Copy link
Contributor Author

Adyg commented Apr 7, 2017

PR for this at #116.

@Adyg Adyg closed this as completed Apr 7, 2017
@DirtyF
Copy link
Member

DirtyF commented Apr 7, 2017

@Adyg Have you successfully tested #116? I don't remember this hiding the nav during my tests.

@ashawley ashawley mentioned this issue Jun 17, 2018
Closed
@jekyll jekyll locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DirtyF @Adyg @jekyllbot