Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logo above site navigation on small screens #6570

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

ashmaroli
Copy link
Member

Current layout

localhost_4000_ logo-below

Proposed layout

localhost_4000_logo-above

@ashmaroli ashmaroli added the site label Nov 20, 2017
@ashmaroli ashmaroli requested a review from DirtyF November 20, 2017 02:35
@DirtyF
Copy link
Member

DirtyF commented Nov 20, 2017

The most significant update here would be to stick the navigation on the bottom on mobile, because we use our thumbs to tap and it's hard to reach the top of the screen.

image

@ashmaroli
Copy link
Member Author

update here would be to stick the navigation on the bottom on mobile

I agree on this, even though the examples you posted above are of native apps and ours is a website.. 😃

@DirtyF
Copy link
Member

DirtyF commented Nov 20, 2017

There's no such things as native apps or websites for our thumbs, I should have posted black screen instead

image

source: https://www.lukew.com/ff/entry.asp?1944

@DirtyF
Copy link
Member

DirtyF commented Nov 20, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit e88b813 into jekyll:master Nov 20, 2017
jekyllbot added a commit that referenced this pull request Nov 20, 2017
@ashmaroli ashmaroli deleted the mobile-docs-header branch November 20, 2017 13:10
@pathawks
Copy link
Member

I don’t think the nav bar should be always visible at the bottom of the screen. Those buttons will not be frequently used–maybe once or twice each session. Making them always visible seems to give them too much prominence.

@ashmaroli
Copy link
Member Author

we can always have a copy of the navbar at the bottom of the page.. then its upto the user to either scroll up or down to a navbar, whichever is nearer..

DirtyF pushed a commit that referenced this pull request Dec 7, 2017
DirtyF pushed a commit that referenced this pull request Dec 7, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants