-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site header redesign #6567
Site header redesign #6567
Conversation
- render site header at full-width using Flexbox - use site color scheme for search input
Nicely done. 👏 On full width on desktop we could:
Now that we use flexbox, I'd like to also display search for lower resolutions and get a full width search on mobile. |
Regarding the version, would it be static or dynamic via with this, search has been opened up for 800px wide and above.. was planning to raise the accessibility in future PRs.. |
For now I guess we could go the easy way with We would link to GitHub release or Rubygems: |
- move link to GitHub repo out of primary nav but remain as is on mobile-devices - add a slot that displays current Jekyll version on large-screens
True. I had modeled it based on your earlier suggestion. But the current suggestion will allow us little more freedom with the search input.. so 👍 The search looks aligned properly to me.. 🤓 🔍 |
- props @DirtyF - render search input from 700px and above
Thanks @ashmaroli, looks great 🙌 Maybe we should move away from gridism at one point if we want more control over the grid? |
@jekyllbot: merge +site |
Yes, like you said a few days ago, it was designed 5 years ago. |
Desktop resolution sample
Sample at 800px viewport-width
Sample at 480px viewport-width