Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test vectors from RFC8032 for ed25519 signatures #266

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

alinradut
Copy link
Contributor

Added test vectors for ed25519 from RFC8032: https://datatracker.ietf.org/doc/html/rfc8032#section-7.1

Copy link
Collaborator

@blochberger blochberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual test code is repetitive, so it could be done with a data-driven approach, but LGTM otherwise. The test vectors match with the RFC.

@jedisct1 jedisct1 merged commit 26c2cc6 into jedisct1:master Apr 24, 2024
@jedisct1
Copy link
Owner

Thank you!

HashMapsData2Value added a commit to algorandfoundation/swift-sodium-full that referenced this pull request May 14, 2024
test: add test vectors from RFC8032 for ed25519 signatures (jedisct1#266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants