Use xcframework only for supported OS #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a hack that may work around a current issue, but depending on another repository, and on different versions of the library doesn't seem like the best way to go. |
|
Yeah, you're right, it's not the best way, but this works. And since binary targets aren't supported on linux, I don't see another way to get this done, except from this workaround. |
|
Now the change is even smaller and it doesn't depend on an external dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not quite a solution for the problem of #224, but it's a running workaround. Otherwise, swift-sodium can't be used on server side projects on Linux - this makes it possible again.