MNT: account for CPython 314 changes #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT
|
fair enough, but I would go with the new name rather than the old one (I think the new one is clearer). |
|
(sorry, could not keep my bikeshedding comments to my self). |
|
Fair enough! Out of curiousity - are you using Python dev w/ msgspec for something? How did you find this compatibility issue? |
jcrist
approved these changes
Oct 24, 2024
|
I have a project that tries to build the development branch of everything (https://github.com/tacaswell/build_the_world) with the goal of catching these things as early as possible. I then try to work in that environment for my day-to-day development. I was playing with msgspec a while ago so it ended up in my build list. |
|
Really great find, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT