Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-446: add black auto-formatter #480

Merged
merged 4 commits into from
Nov 9, 2018
Merged

GH-446: add black auto-formatter #480

merged 4 commits into from
Nov 9, 2018

Conversation

rossmechanic
Copy link
Collaborator

@rossmechanic rossmechanic commented Nov 9, 2018 •
edited
Loading

Description

Copy of #447 from @JamesMura with some changes we wanted before merging. Reference #447 for full description.

Related Issue

Fixes #446 .

Motivation and Context

Adds autoformatting using black

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rossmechanic rossmechanic changed the title Gh 443 add black autoformatter GH-443" add black auto-formatter Nov 9, 2018
@rossmechanic rossmechanic changed the title GH-443" add black auto-formatter GH-443: add black auto-formatter Nov 9, 2018
@rossmechanic rossmechanic changed the title GH-443: add black auto-formatter GH-446: add black auto-formatter Nov 9, 2018
@codecov-io
Copy link

codecov-io commented Nov 9, 2018 •
edited
Loading

Codecov Report

Merging #480 into master will not change coverage.
The diff coverage is 97.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          16       16           
  Lines         713      713           
  Branches       94       94           
=======================================
  Hits          693      693           
  Misses         10       10           
  Partials       10       10
Impacted Files Coverage Δ
...tomattrforeignkey_modelwithcustomattrforeignkey.py 100% <ø> (ø) ⬆️
simple_history/exceptions.py 100% <ø> (ø) ⬆️
simple_history/middleware.py 88.88% <0%> (ø) ⬆️
simple_history/admin.py 97.97% <100%> (ø) ⬆️
simple_history/utils.py 100% <100%> (ø) ⬆️
...ests/migration_test_app/migrations/0001_initial.py 100% <100%> (ø) ⬆️
...le_history/management/commands/populate_history.py 93.81% <100%> (ø) ⬆️
..._history/templatetags/simple_history_admin_list.py 100% <100%> (ø) ⬆️
simple_history/signals.py 100% <100%> (ø) ⬆️
simple_history/__init__.py 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3a2c1...31f5c57. Read the comment docs.

@rossmechanic rossmechanic merged commit 0f522f9 into master Nov 9, 2018
@rossmechanic rossmechanic mentioned this pull request Nov 9, 2018
Closed
9 tasks
@rossmechanic rossmechanic deleted the gh-443-add-black-autoformatter branch December 5, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kseever kseever kseever approved these changes

@ThePumpingLemma ThePumpingLemma Awaiting requested review from ThePumpingLemma

@barm barm Awaiting requested review from barm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Black auto formatter
3 participants
@rossmechanic @codecov-io @kseever