Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass start at time to stop invoke #480

Merged
merged 6 commits into from
Jul 15, 2022
Merged

pass start at time to stop invoke #480

merged 6 commits into from
Jul 15, 2022

Conversation

EdgyEdgemond
Copy link
Contributor

closes #396

@jmaupetit
Copy link
Contributor

Thank you for this @EdgyEdgemond 🙏 Can you add a test for this fix please?

@EdgyEdgemond
Copy link
Contributor Author

sure thing, was trying to find an existing start/stop test, hadn't located it yet

jmaupetit
jmaupetit approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jmaupetit jmaupetit merged commit d9de4fc into jazzband:master Jul 15, 2022
@EdgyEdgemond EdgyEdgemond deleted the fix/396 branch July 15, 2022 11:55
@jmaupetit jmaupetit mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"start --at" fails when stopping a current project
2 participants
@EdgyEdgemond @jmaupetit