Stylize prompt for new project and tags #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I didn't break the test, but it works now!) |
jmaupetit
reviewed
Sep 9, 2019
| @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Add CSV output format support for `report`, `log` and `aggregate` commands | |||
| using the `--csv/-s` command line option flag (#281). | |||
| - Add `start --confirm-new-project` and `start --confirm-new-tag` options and | |||
| corresponding options to configuration (#275). | |||
There was a problem hiding this comment.
🙏 Can you also update the corresponding section in the CHANGELOG please?
jmaupetit
reviewed
Sep 9, 2019
k4nar
previously approved these changes
Sep 9, 2019
@jmaupetit Done! |
jmaupetit
reviewed
Sep 9, 2019
Co-Authored-By: Julien Maupetit <jmaupetit@users.noreply.github.com>
jmaupetit
approved these changes
Sep 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #191 & #275, this stylizes the prompt to that the project or tag name is highlighted.
The other place this might make sense to add is when
Watsondisplays an error message when you try to start a new project with--no-gapbut have an active project (cli.py, line 221-223); however, stylizing the project here breaks the colouring of the error message. This does update the typographical styling to be consistent with the above.Further to #303, this also add these new options to the Release Notes for v1.8.0.