Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.4 support #286

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

davidag
Copy link
Contributor

@davidag davidag commented Jun 10, 2019

Remove references to Python 3.4 in Travis and Tox config. Also in Python doc links in Watson documentation.

Tox was failing in Travis due to a critical error installing arrow. This was due to Python 3.4 support being deprecated since March 2019.

The error was:

ERROR: arrow requires Python '>=2.7, !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*' but the running Python is 3.4.6

A warning message is shown when running Python 3.4:

DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).

@davidag davidag force-pushed the drop-python-34-support branch from ded8cfb to 7e59219 Compare June 10, 2019 21:11
@jmaupetit jmaupetit self-requested a review June 11, 2019 08:20
@jmaupetit
Copy link
Contributor

jmaupetit commented Jun 11, 2019

Hey @davidag thank you for your contribution, can you please update the CHANGELOG?

k4nar
k4nar previously approved these changes Jun 11, 2019
Copy link
Collaborator

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (with a Changelog entry ;) )

Remove references to Python 3.4 in Travis and Tox config. Also in
Python doc links in Watson documentation.

Tox was failing in Travis due to a critical error installing arrow. This
was due to Python 3.4 support being deprecated since March 2019.
@davidag
Copy link
Contributor Author

davidag commented Jun 12, 2019

@jmaupetit Done!

@jmaupetit jmaupetit merged commit 5a11241 into jazzband:master Jun 12, 2019
@jmaupetit jmaupetit mentioned this pull request Aug 26, 2019
@davidag davidag deleted the drop-python-34-support branch October 16, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants