-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Shell32.SHGetKnownFolderPath and corresponding constants #334
Conversation
* that is not present on the system. Not all KNOWNFOLDERID values are present on all systems. Use | ||
* IKnownFolderManager::GetFolderIds to retrieve the set of KNOWNFOLDERID values for the current system.</li> | ||
*/ | ||
HRESULT SHGetKnownFolderPath(GUID rfid, int dwFlags, HANDLE hToken, PointerByReference ppszPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use LPSTR.ByReference here, but the returned string was garbage. Can't really explain why ..
This is good. Check out my comments on |
I ended up doing both: I changed the inheritance of |
That looks good. |
Merging, nice work. |
Added Shell32.SHGetKnownFolderPath and corresponding constants
…ive-access#334) Motivation: The tree includes 'Maven Wrapper' with settings such that it downloads Maven 3.8.1 from the ASF 'backup' distribution servers, rather than the main distribution mirrors, or more typically in the wrappers case actually Maven Central (which it seems the settings did use prior to the last config update). As the CI jobs are grabbing Maven several times for every commit, plus adding on any related use from peoples Netty forks/downloads etc, this will add up. It would be good to direct them elsewhere. Modifications: Change url Result: Less load on the apache backup download server
No description provided.