Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shell32.SHGetKnownFolderPath and corresponding constants #334

Merged
merged 3 commits into from
May 26, 2014

Conversation

msteiger
Copy link
Contributor

No description provided.

* that is not present on the system. Not all KNOWNFOLDERID values are present on all systems. Use
* IKnownFolderManager::GetFolderIds to retrieve the set of KNOWNFOLDERID values for the current system.</li>
*/
HRESULT SHGetKnownFolderPath(GUID rfid, int dwFlags, HANDLE hToken, PointerByReference ppszPath);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use LPSTR.ByReference here, but the returned string was garbage. Can't really explain why ..

@dblock
Copy link
Member

dblock commented May 24, 2014

This is good. Check out my comments on CoTaskMemFree and the tests.

@msteiger
Copy link
Contributor Author

I ended up doing both: I changed the inheritance of LPVOID as discussed with @twall, but use plain Pointer instances which are more natural to work with.

@dblock
Copy link
Member

dblock commented May 26, 2014

That looks good.

@dblock
Copy link
Member

dblock commented May 26, 2014

Merging, nice work.

dblock added a commit that referenced this pull request May 26, 2014
Added Shell32.SHGetKnownFolderPath and corresponding constants
@dblock dblock merged commit 296e89e into java-native-access:master May 26, 2014
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…ive-access#334)

Motivation:

The tree includes 'Maven Wrapper' with settings such that it downloads Maven 3.8.1 from the ASF 'backup' distribution servers, rather than the main distribution mirrors, or more typically in the wrappers case actually Maven Central (which it seems the settings did use prior to the last config update). As the CI jobs are grabbing Maven several times for every commit, plus adding on any related use from peoples Netty forks/downloads etc, this will add up. It would be good to direct them elsewhere.

Modifications:

Change url

Result:

Less load on the apache backup download server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants