@TomHall2020 and @LiamPattinson please do take a look and let me know your comments.
If you would be happy to review please let me know and I'll add you.
I'd suggest starting with the new docs from this MR which can be found here.

Yeah would be happy to review on this. Will pull down the fork and play with it interactively too, but the new public API does look way better (good riddance HcParams!)

Had to stop my review there, don't know if it was the diffs or my browser but the github web interface just started going nuts. Most of what I've picked up on is the implicit coupling of desc_scale to handicap system specific data in the base HandicapScheme class, should be fairly easy to fix. Otherwise absolutely way hapier with the API, I can build a round and get useful information on it in a REPL so much more easily than before

from archeryutils import Round, Pass, Target
from archeryutils import handicaps as hc

t = Target("5_zone", (48, "inch"), (80, "yards"))
p = Pass(30,t)
r = Round('Test', [p,p,p])

hc.score_for_round(r, 30, "AGB")
hc.handicap_from_score(700, r, "AGB")

Much more intuitive than the previous version and I appreciate the reduced imports as well. Even though I'd got familiar with the codebase by now, from a dev point of view the file layout now also feels more intuitive too.

@LiamPattinson @TomHall2020 I have updated the docs which was the last TODO from my end.
I believe I have also addressed the points raised above in review.

If I can get closure of those and an approving review I will merge this which should unblock a number of your PRs @TomHall2020 and bring us very close to completing #49.

Codecov Report

Attention: Patch coverage is 97.18004% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 97.66%. Comparing base (3d94e2b) to head (6d07d58).

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   96.07%   97.66%   +1.59%     
==========================================
  Files          24       28       +4     
  Lines        1426     1499      +73     
==========================================
+ Hits         1370     1464      +94     
+ Misses         56       35      -21     

OK, great.

If you are happy please could you do a review with "Approve" selected @TomHall2020?
(Go to Files Changed, select green review button, add a message and then select the "Approve" radio button instead of "Comment".)
That should then unlock it for me to merge (I put branch protection rules on now that there is more than just me opening PRs).

If you are happy please could you do a review with "Approve" selected @TomHall2020? (Go to Files Changed, select green review button, add a message and then select the "Approve" radio button instead of "Comment".) That should then unlock it for me to merge (I put branch protection rules on now that there is more than just me opening PRs).

I've reviewed and approved already, but from the status bar below it looks like the repo is set to require an approving review from someone with write access, so that might be the issue you're having.

I've added my approval and I'm seeing the same issue: at least 1 approving review is required by reviewers with write access.

Thanks folks - feels great to get this one finally checked off!

@TomHall2020 if you can update your open PRs to use this (I know you already rebased one) then hopefully they can follow soon.